-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Add Variable PAK Times #6832
Conversation
Alters PAK time function to use user-defined variables for min and max PAK time instead of hard-coded values.
Introduces variables in medical settings to allow users to set custom minimum and maximum PAK times.
Introduces DisplayName and Description strings for custom minimum and maximum PAK time settings.
Added myself (RulingCommander) to Contributors, with valid email.
I'm not as active here these days so take my opinion with a grain of salt, but personally I think a coefficient is more suitable here. |
I agree, you avoid problems with assigning a higher value to min than to max. |
Introduced settings for minimum and maximum PAK times, where min must be set less than max.
Replaces Max PAK time with a coefficient, causes Max PAK time to be derived from Min PAK time multiplied by the coefficient.
Using a coefficient is a good idea, hadn't occurred to me. Updated to now use minimum time and a coefficient settings, where the maximum time comes from minimum * coefficient. |
Rewrite has changed quite a bit, current setting is "How long should PAK take to apply? Use 0 for default (based on damage)" edit: propose chaning to just a coefficent with a min of ~10 sec |
I had the minimum also be adjustable instead of remaining 10 seconds to allow for a bit more customizability. You can force a single time by setting the coefficient to 1, or keep damage scaling with different mins and maxes. I can look into combining my changes with yours, if you're interested in that. |
#6933 added a setting for fullHeal scaling coefficent (with a constant 10sec min) |
since 3.13 medical now contains a setting inspired by this PR |
When merged this pull request will: