Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Add Variable PAK Times #6832

Closed
wants to merge 6 commits into from
Closed

Conversation

Ruling-0
Copy link

@Ruling-0 Ruling-0 commented Feb 23, 2019

When merged this pull request will:

  • Introduce new settings in the ACE Medical settings: PAK Time Minimum and PAK Time Coefficient.
  • Use variable Min and Max PAK time settings in place of hard-coded values for PAK time. Max PAK time will be derived from Min * Coefficient.
  • Add stringtable.xml entries for newly defined Min and Coefficient PAK time settings.

Alters PAK time function to use user-defined variables for min and max PAK time instead of hard-coded values.
Introduces variables in medical settings to allow users to set custom minimum and maximum PAK times.
Introduces DisplayName and Description strings for custom minimum and maximum PAK time settings.
Added myself (RulingCommander) to Contributors, with valid email.
@kymckay
Copy link
Member

kymckay commented Feb 24, 2019

I'm not as active here these days so take my opinion with a grain of salt, but personally I think a coefficient is more suitable here.

@TheMagnetar
Copy link
Member

I agree, you avoid problems with assigning a higher value to min than to max.

Ruling-0 and others added 2 commits February 24, 2019 17:14
Introduced settings for minimum and maximum PAK times, where min must be set less than max.
Replaces Max PAK time with a coefficient, causes Max PAK time to be derived from Min PAK time multiplied by the coefficient.
@Ruling-0
Copy link
Author

Using a coefficient is a good idea, hadn't occurred to me. Updated to now use minimum time and a coefficient settings, where the maximum time comes from minimum * coefficient.

@PabstMirror
Copy link
Contributor

PabstMirror commented May 11, 2019

Rewrite has changed quite a bit,
https://github.com/acemod/ACE3/blob/master/addons/medical_treatment/functions/fnc_healTime.sqf

current setting is "How long should PAK take to apply? Use 0 for default (based on damage)"

edit: propose chaning to just a coefficent with a min of ~10 sec

@Ruling-0
Copy link
Author

I had the minimum also be adjustable instead of remaining 10 seconds to allow for a bit more customizability. You can force a single time by setting the coefficient to 1, or keep damage scaling with different mins and maxes. I can look into combining my changes with yours, if you're interested in that.

@PabstMirror
Copy link
Contributor

#6933 added a setting for fullHeal scaling coefficent (with a constant 10sec min)
https://github.com/acemod/ACE3/blob/master/addons/medical_treatment/functions/fnc_getHealTime.sqf

@PabstMirror
Copy link
Contributor

since 3.13 medical now contains a setting inspired by this PR
see https://github.com/acemod/ACE3/blob/master/addons/medical_treatment/functions/fnc_getHealTime.sqf#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants