-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interaction - Show all possible modes for an attachment #8154
Conversation
PabstMirror
commented
Mar 7, 2021
Tested, works. I would suggest to move these actions from |
Maybe make it so it goes Weapon Attachments -> [Array of attachments] -> [Mode, Detach, etc.]? |
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
I fully agree with that, given we're adding some new actions. I went ahead and pushed the necessary changes. I've addressed the PIP scopes issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but given I've rewritten part of the code, I'd like another person to take a second look at this.
Done for both attach and detach. |
* Interaction - Show all possible modes for an attachement * Move attach & detach actions under item action * Remove switching from PIP to regular 2D * Remove attachment name from attach/detach actions * Fixed typo in variable name --------- Co-authored-by: johnb432 <[email protected]>