Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Change CBA Namespaces to HashMap #8801

Merged
merged 32 commits into from
Jun 11, 2024
Merged

General - Change CBA Namespaces to HashMap #8801

merged 32 commits into from
Jun 11, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Change count loops to forEach where appropriate.
  • Change FUNC to LINKFUNC macro in eventhandlers where appropriate.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim marked this pull request as draft January 26, 2022 14:13
@BrettMayson BrettMayson changed the title WIP - General - Change CBA Namespaces to HashMap General - Change CBA Namespaces to HashMap Oct 16, 2023
This was referenced Mar 27, 2024
Merged
Merged
@johnb432 johnb432 mentioned this pull request Apr 4, 2024
Merged
@johnb432 johnb432 marked this pull request as ready for review April 10, 2024 18:39
@johnb432
Copy link
Contributor

@LinkIsGrim Can you take a look at this?

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Apr 20, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Apr 20, 2024
@johnb432 johnb432 self-requested a review May 26, 2024 08:39
LinkIsGrim
LinkIsGrim commented May 29, 2024
View reviewed changes
Copy link
Contributor Author

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through it. Should get around to replacing get + isNil with getOrDefaultCall eventually (HEMTT catch?), but separate PR for that.

@dedmen
Copy link
Contributor

dedmen commented May 29, 2024

I am in favor of this

LinkIsGrim
LinkIsGrim commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go when comments are addressed

LinkIsGrim
LinkIsGrim commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim
Copy link
Contributor Author

what could go wrong

@LinkIsGrim LinkIsGrim merged commit 59af3e1 into acemod:master Jun 11, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the namespaces-to-hashmaps branch June 11, 2024 15:34
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@LinkIsGrim @johnb432 @blake8090
General - Change CBA Namespaces to HashMap (acemod#8801)
f5823d0 
* medical_treatment

* advanced_throwing

* common, csw

* Update fnc_replaceRegisteredItems.sqf

* Sanitised numerous components

* Update XEH_postInit.sqf

* Update XEH_postInit.sqf

* FUNC -> LINKFUNC

* Changed tagging hashmap

* Reverted some changes

* Reverted some changes

* Update XEH_clientInit.sqf

* Tweaks and fixes

* Fix number replacements

* Minor cleanup

* Update fnc_getMagazineName.sqf

* Update fnc_getMagazineName.sqf

* Minor improvement

* Made factions case-sensitive and added `toLowerANSI` to be safe

* Update fnc_getDetectedObject.sqf

* Update addons/common/functions/fnc_actionKeysNamesConverted.sqf

Co-authored-by: Grim <[email protected]>

* Throw error if item doesn't exist

---------

Co-authored-by: Salluci <[email protected]>
Co-authored-by: johnb432 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LinkIsGrim @johnb432 @dedmen @PabstMirror