-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Add Cellphone/Detonator Keybinds #9687
Explosives - Add Cellphone/Detonator Keybinds #9687
Conversation
This allows ace_interact_menu_consolidateSingleChild to collapse trigger interactions for a single explosive code.
Triggers all explosives on current "active clacker", which auto-assigns to first connected clacker and is re-assignable via clacker self-interactions.
I'd leave defaults for detonation unbound. Alt is used for freelook and C for toggling combat pace, and both are used frequently. A "Cycle Active Detonator" keybind would be nice, as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the whole, not a fan of the checks that are case sensitive (I realise that it was already a problem before this PR, but we shouldn't make it worse).
Co-Authored-By: Grim <[email protected]> Co-Authored-By: johnb432 <[email protected]>
Co-authored-by: johnb432 <[email protected]>
Code LGTM, review after testing. Side-note: looking at the explosives component in general is giving me a headache. |
Done 👌🏻 |
Co-authored-by: johnb432 <[email protected]>
I believe this is pretty much complete. |
Reviewing this without getting distracted by the rest of the explosives module is a challenge but I'll get to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than above
Co-authored-by: johnb432 <[email protected]>
Co-authored-by: johnb432 <[email protected]>
Co-authored-by: johnb432 <[email protected]>
When merged this pull request will:
Add
Cellphone
Keybind (unbound by default) to open the Cellphone interface;Add
Detonate All on Active Detonator
Keybind (unbound by default) to detonate all explosives tied to the currentActive Detonator
;When connecting the first explosive to a detonator, that detonator will be selected as the active one, afterwards it's possible to switch the
Active Detonator
as desired via aSet Active Detonator
interaction on any non-active detonator;Add
Cycle Active Detonator
Keybind (unbound by default) to cycle between the currently carried triggers, thereby selecting which is theActive Detonator
, is visualized byCBA Notification
common/fnc_displayTextPicture
;Only show
Detonate All
interaction on a detonator if connected to more than 1 explosive, to allow theace_interact_menu_consolidateSingleChild
setting to consolidate that interaction;