Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Exit refresh early if no display is found #9754

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Jan 22, 2024

When merged this pull request will:

  • Title.
  • Wait a frame before display no virtual items notification when removing a box, in case the removal is being done during display close.

@Mike-MF please test if this handles your case

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Jan 22, 2024
@LinkIsGrim LinkIsGrim added this to the 3.16.4 milestone Jan 22, 2024
@@ -22,7 +22,7 @@ GVAR(lastSortDirectionRight) = DESCENDING;
params ["_object"];

// If the arsenal is already open, refresh arsenal display
if (!isNil QGVAR(currentBox) && {GVAR(currentBox) isEqualTo _object}) then {
if (!isNull GVAR(currentBox) && {GVAR(currentBox) isEqualTo _object}) then {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GVAR(currentBox) will only be nil during preInit

Co-authored-by: Mike-MF <[email protected]>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim LinkIsGrim merged commit 6c60b67 into master Feb 5, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the arsenal-prevent-useless-notif branch February 5, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants