Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hearing - Keybind for putting or taking out earplugs #9804

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Hearing - Keybind for putting or taking out earplugs #9804

merged 4 commits into from
Feb 28, 2024

Conversation

prisonerMO
Copy link
Contributor

@prisonerMO prisonerMO commented Feb 26, 2024 •
edited by johnb432
Loading

When merged this pull request will:

  • This request will add keybind for put or take out earplug
  • Default ALT+H unbound
  • Addon Controls -> ACE Equipment

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@jonpas
Copy link
Member

jonpas commented Feb 26, 2024

What is the benefit in a keybind?

@veteran29
Copy link
Member

IMO should be unassigned by default.

@prisonerMO
Copy link
Contributor Author

IMO should be unassigned by default.

Yeah.
That would be better.

@johnb432 johnb432 self-requested a review February 26, 2024 15:44
@johnb432
Copy link
Contributor

What is the benefit in a keybind?

Like some other keybinds in ACE: It's more convenient and faster than going through the menu. Adding the possibility to bind a key to toggle earplugs doesn't impact the game in a negative way, imo, especially if it's left unbound by default.

johnb432
johnb432 requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for a first PR!

addons/hearing/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/hearing/initKeybinds.inc.sqf Outdated Show resolved Hide resolved
addons/hearing/stringtable.xml Outdated Show resolved Hide resolved
@johnb432 johnb432 changed the title Keybind for put or take out earplugs Hearing - Keybind for putting or taking out earplugs Feb 26, 2024
@prisonerMO
Copy link
Contributor Author

Good for a first PR!

Thanks!
Thank you very much for clarifying how it should be done/what is done elsewhere and for correcting the code

prisonerMO and others added 3 commits February 26, 2024 21:47
@prisonerMO @johnb432
Update addons/hearing/XEH_postInit.sqf
38d4fec 
Don't need to register keybinds on machines that don't have interfaces.

Co-authored-by: johnb432 <[email protected]>
@prisonerMO @johnb432
Update addons/hearing/initKeybinds.inc.sqf
f38f637 
Removed default keybind, added new line at the end of the file and changed some code formatting, as well as some functions:

Co-authored-by: johnb432 <[email protected]>
@prisonerMO @johnb432
Update addons/hearing/stringtable.xml
e2db34b 
Co-authored-by: johnb432 <[email protected]>
@PabstMirror PabstMirror added this to the 3.17.0 milestone Feb 28, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Feb 28, 2024
@PabstMirror PabstMirror merged commit 8a67744 into acemod:master Feb 28, 2024
5 checks passed
@prisonerMO prisonerMO deleted the ace_hearing_keybind branch February 28, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@prisonerMO @jonpas @veteran29 @johnb432 @PabstMirror @LinkIsGrim