-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General - Events for Mods #9813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Mar 2, 2024
Working fine with a version of KAM that requires it. |
PabstMirror
reviewed
Mar 3, 2024
LinkIsGrim
reviewed
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Documentation in events-framework page?
LinkIsGrim
approved these changes
Mar 4, 2024
LinkIsGrim
reviewed
Mar 4, 2024
Co-authored-by: Grim <[email protected]>
veteran29
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
PabstMirror
approved these changes
Mar 4, 2024
MiszczuZPolski
pushed a commit
to KAT-Advanced-Medical/KAM
that referenced
this pull request
Apr 1, 2024
**When merged this pull request will:** - Chemical is now modular - Surgery is now modular - Pharma is now modular - Create ACE events so that KAM doesn't need to overwrite some files **Semi Related** - Update to support ACE's new maxDoseDeviation Requires: - acemod/ACE3#9813 - acemod/ACE3#9816 Moved from KAM to ACE: - acemod/ACE3#9817 - acemod/ACE3#9815 Currently removed, needs to be added to ACE: - Show inactive status setting for medical_gui ### IMPORTANT - [Development Guidelines](https://ace3.acemod.org/wiki/development/) are read, understood and applied. - Title of this PR uses our standard template `Component - Add|Fix|Improve|Change|Make|Remove {changes}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, mainly for KAM
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.