Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Don't add keybinds to headless client/dedicated server #9842

Merged
merged 3 commits into from
Mar 12, 2024
Merged

General - Don't add keybinds to headless client/dedicated server #9842

merged 3 commits into from
Mar 12, 2024

Conversation

prisonerMO
Copy link
Contributor

When merged this pull request will:

  • removes register keybinds on machines that don't have interfaces.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

LinkIsGrim
LinkIsGrim requested changes Mar 9, 2024
View reviewed changes
addons/rangecard/XEH_postInit.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim changed the title Ace keybinds General - Don't add keybinds to headless client/dedicated server Mar 9, 2024
@LinkIsGrim LinkIsGrim added the kind/change Release Notes: **CHANGED:** label Mar 9, 2024
@mharis001
Copy link
Member

Is this needed?

https://github.com/CBATeam/CBA_A3/blob/master/addons/keybinding/fnc_addKeybind.sqf#L84

LinkIsGrim
LinkIsGrim approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly needed, but doesn't hurt.

@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 10, 2024
@johnb432 johnb432 merged commit 5e1771a into acemod:master Mar 12, 2024
5 checks passed
@prisonerMO prisonerMO deleted the ace_keybinds branch March 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prisonerMO @mharis001 @johnb432 @LinkIsGrim