Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes - Notify restart req. for enable & pressure settings #9944

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Scopes - Notify restart req. for enable & pressure settings #9944

merged 2 commits into from
Apr 11, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 10, 2024 •
edited
Loading

When merged this pull request will:

  • Title.
  • They always required a mission restart to change the setting, but now the user is informed about it.
  • Moved keybinds into separate file and register them, regardless of if scopes are enabled.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Apr 10, 2024
@johnb432 johnb432 added this to the 3.17.1 milestone Apr 10, 2024
rautamiekka
rautamiekka reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Mandatory comment because GitHub requires it to only give a comment.)

@johnb432 johnb432 merged commit bcf1133 into master Apr 11, 2024
5 checks passed
@johnb432 johnb432 deleted the scope-settings branch April 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@Mike-MF Mike-MF Mike-MF approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.17.1
Development

Successfully merging this pull request may close these issues.
5 participants
@johnb432 @rautamiekka @PabstMirror @Mike-MF @LinkIsGrim