Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: error when taking gradients with nv = 0 or nx = 0 #101

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Bugfix: error when taking gradients with nv = 0 or nx = 0 #101

merged 8 commits into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. Bug still there when nu, ny = 1

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    730ee83 View commit details
    Browse the repository at this point in the history

  2. Minor edits

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    69d08df View commit details
    Browse the repository at this point in the history

  3. Isolated the bug in an example

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    92743b7 View commit details
    Browse the repository at this point in the history

  4. Reduced minimal example of bug

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0a344a4 View commit details
    Browse the repository at this point in the history

  5. Created new test for this bug

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0c649c2 View commit details
    Browse the repository at this point in the history

  6. Found a slow fix with if statements on bias vectors

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a92ea1e View commit details
    Browse the repository at this point in the history

  7. Added check for zero-dim bias vectors

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ac9099a View commit details
    Browse the repository at this point in the history

  8. Added test for nx = 0, nv = 0

    @nic-barbara
    nic-barbara committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    be6281e View commit details
    Browse the repository at this point in the history