Implements subscribe button and dialogue #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jongomez
force-pushed
the
implement-subscribe-button-and-dialogue
branch
from
bd75de8
to
ee7ad04
Compare
jongomez
commented
Oct 26, 2023
Comment on lines
+124
to
+127
|
|
||
| ${(props) => lsdUtils.breakpoint(props.theme, 'xs', 'down')} { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Decided to hide the "Network State Press" text on the header for small screens. This has not yet been confirmed by Eddy, so it may change.
jongomez
changed the title
jeangovil
approved these changes
Oct 26, 2023
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements subscribe button and dialogue.
Related Issue(s):
(none)
Changes Included:
Implementation Details:
A subscribe button was added to the navbar. When the button is clicked, it opens up a modal / dialogue with a form. It then makes an API call to an endpoint created by @jeangovil - this endpoint sends the subscription info to odoo.
Testing:
We can easily interact with this UI by clicking on the "Subscribe" button at the top. There is a mockOnSubmit function that can be used to test the submition states (submitting, success, fail)
Checklist: