Filling in a few first names #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete` attribute, even if the paper didn't originally have a middle initial. Deleted entry for "Robert Mercer" from `name_variants.yaml`. For now, "Robert Mercer" will have a separate page from "Robert E. Mercer" and "Robert L. Mercer"; when the code is modified to look at the `complete` attribute, this should go away. If this looks okay, there's at least one other pair of authors that can be disambiguated in this way.
|
The error has to do with TeX and nothing to do with author names (AFAICT)...did something change with a new version of TeXSoup? |
|
Looks like it, they released 0.2.0 just yesterday. I hotfixed it in #261. |
|
Thanks! |
najtin
pushed a commit
to ir-anthology/ir-anthology
that referenced
this pull request
Jun 9, 2021
Filling in a few first names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here eliminates the square brackets in one author's name that I thought was too collision prone (discussed at #217 (comment)).
The second commit uses the
completeattribute to resolve the ambiguous author name "Robert Mercer" (discussed at #208). My thought is that in this type of situation, thecompleteattribute is sufficient for disambiguation, and this is the right way to do it. I'm trying out this one case so you can see how it looks. If it looks good, there's at least one other I'm aware of, but probably more.