Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3036. Change author metadata towards merging two profiles for … #3037

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

pruizf
Copy link
Contributor

@pruizf pruizf commented Jan 17, 2024

The problem is described in issue #3036. Two profiles were created for me. Is it possible to merge them towards the newer one?

These are the profiles:

It can be seen at ORCID that it's the same person https://orcid.org/0000-0002-4349-4835), or at my university site (https://lilpa.unistra.fr/theme-1-lexiques-discours-et-transpositions/membres/enseignants-chercheurs/ruiz-fabo-pablo/), which should be pulling publications automatically from the French national open repository (https://cv.hal.science/pabloruizfabo).

Would it be possible to merge both profiles towards the newer one? Even if it has one paper only, it mentions both my last names. In papers since 2016, I wrote both last names for the author name on the PDF, but only one last name on the PDF in 2014 and 2015.

So I have 3 papers with "Pablo Ruiz Fabo" as author on the PDF and 4 papers with "Pablo Ruiz" as author on the PDF. The e-mail addresses do mention both my last names in all papers but the oldest one.

Going forward I will write my name using the long version with two last names, which is why I suggest to merge towards the newer profile even if it now has less papers than the other profile.

I tried to make the change in this PR, looking at similar issues on profile merging. Could you please advise if it's OK?

Thanks a lot for your time

…the same author, under two different names
@pruizf pruizf mentioned this pull request Jan 17, 2024
3 tasks
@akoehn
Copy link
Member

akoehn commented Jan 17, 2024

Looks good to me, but you will be able to check this once the preview is ready. I enabled the preview generation for this pr.

@akoehn
Copy link
Member

akoehn commented Jan 17, 2024

Ah, my bad. The preview is only triggered for internal PRs. Compiling it locally should show whether everything works as expected but I'm on mobile right now.

@pruizf
Copy link
Contributor Author

pruizf commented Jan 17, 2024

Thank you for the quick answer! I'll look forward to whether it builds correctly.

@mjpost mjpost linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
@mjpost
Copy link
Member

mjpost commented Jan 17, 2024

This is possible, and thanks for the PR! However, can you please remove the id: key from the name variants file, and the id= attribute from the XML? That's only needed when the same name is used by two different people. Your situation (where the same person uses multiple names) is simpler, and will be handled just by creating the name variant.

Once you do this, I'll merge it and it will be live.

(The reason to remove the ID is because once it's in there, we have to add it for all future papers, which slightly complicates the ingestion at the moment).

@mjpost
Copy link
Member

mjpost commented Jan 17, 2024

One other thing: We take the PDF as the "ground truth". This means that if your name is "Pablo Ruiz" in the PDF, please leave it that way in the metadata. The papers will all be joined under the same canonical variant of your name due to the entry in the name variants file.

@pruizf
Copy link
Contributor Author

pruizf commented Jan 17, 2024

Thanks a lot for the quick response and detailed explanation. I removed the id: key from the yaml and the id attributes in the metadata XML. And the last names in the XML match the PDF.

@mjpost mjpost merged commit cc91dd9 into acl-org:master Jan 17, 2024
1 check passed
@mjpost
Copy link
Member

mjpost commented Jan 17, 2024

Done. Should be live in about a half hour: https://aclanthology.org/people/pablo-ruiz-fabo

@pruizf
Copy link
Contributor Author

pruizf commented Jan 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author Metadata: Pablo Ruiz Fabo
3 participants