Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Name Variant for Genta Winata #3747

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

gentaiscool
Copy link
Contributor

@gentaiscool gentaiscool commented Aug 14, 2024

This PR updates the name variants for Genta Winata and Genta Indra Winata (I have 2 different ACL anthology user pages).
https://aclanthology.org/people/g/genta-winata/
https://aclanthology.org/people/g/genta-indra-winata/

Thanks

@gentaiscool gentaiscool changed the title Add Middle Name to the Paper Metadata Add Middle Name to the Paper Metadata For Consistency Aug 14, 2024
@nschneid
Copy link
Contributor

Thanks for raising this. Anthology policy is to follow the PDF for metadata, and at least https://aclanthology.org/2024.findings-acl.147/ has no middle name in the PDF. The two name variants can be registered at https://github.com/acl-org/acl-anthology/blob/master/data/yaml/name_variants.yaml so they will show up on the same page.

@gentaiscool
Copy link
Contributor Author

Thank you @nschneid for the useful pointer. I reverted my changes and only added a variant for my name page.

@gentaiscool gentaiscool changed the title Add Middle Name to the Paper Metadata For Consistency Add Name Variant for Genta Winata Aug 14, 2024
@nschneid nschneid merged commit b9c9be8 into acl-org:master Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants