-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements #443
UI improvements #443
Conversation
To prevent visual clutter, only the top 5 are shown by default, but there is now a button to show the full co-author/venue list. Also reduced the padding slightly to make the lists more compact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. We should push it out.
I think a 1 MB event page isn't anything to worry about. I agree the buttons are getting crowded. I'm not sure what to do. One idea is to reserve a fixed space to the right of the title, and put some less-essential buttons there, in a fixed format (so that one could scroll down and see easily which papers had a particular attachment type). But I don't think we need to solve that in this PR. |
What I'd particularly like is if the paper titles and author lists were lined up on the left, and didn't jump around depending on the number of attachments. :) I'll refactor the ugly template code later and then give this a go. |
Now that you mention it, that is bothersome :) What about keeping (PDF, BIB, search) to the left, and putting all the others to the right of the title (right-justified)? |
I think keeping all of the actions on the left is better since from an
HCI perspective, all of the action are clustered and have less travel
distance.
For whatever reason it allows the entire set of tiles to live together and
not be scrolled off to the right of a small screen (if not wrapped).
I'm ok with the second layout but it may incur button mispresses. Also,
with the intended move to variable length identifiers, spacing would be
different per venue, and may look odd if not properly justified in mixed
venue output (e.g., search results).
Cheers,
Min
…--
Min-Yen KAN (Dr) :: Associate Professor :: National University of Singapore
:: NUS School of Computing, AS6 05-12, 13 Computing Drive
Singapore 117417 :: +65 6516 1885(DID) :: +65 6779 4580 (Fax) ::
[email protected] (E) :: www.comp.nus.edu.sg/~kanmy (W)
On Fri, Jul 12, 2019 at 11:13 PM Marcel Bollmann ***@***.***> wrote:
What about keeping (PDF, BIB, search) to the left, and putting all the
others to the right of the title (right-justified)?
I'm not quite convinced...
[image: image]
<https://user-images.githubusercontent.com/11348502/61128992-bb4d0900-a4b3-11e9-995f-5dddc53299b5.png>
How useful/important do you think it is having the ACL IDs displayed in
these lists? If we got rid of these here, maybe this would work:
[image: image]
<https://user-images.githubusercontent.com/11348502/61138621-2b658a00-a4c8-11e9-981b-2a2aecd03564.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#443?email_source=notifications&email_token=AABU72244MKKUJEDT5W2C5DP7CNP3A5CNFSM4H44IVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2BJDI#issuecomment-510923917>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABU72YTUQ4QLU4PLQ5A3DTP7CNP3ANCNFSM4H44IVOA>
.
|
Yes, you two are right. I really like your latest button mockup. I do wonder if I'd miss having the Anthology IDs which I use often, but my use case (debugging changes to the Anthology!) is probably not very common. What about listing the IDs after the title in white text—this way, they could be searched for, but wouldn't be visible. e.g.,
(or maybe put the ID on the title line, but right justified, so one could also page through and easily track IDs? This is looking very nice. |
I really like how the title and author lines now line up vertically. If those are in the same |
I think (b) would add a lot of redundancy. It will be noticeable when you're scrolling through the full list of papers looking for something. But I'll keep #412 in mind when playing around with these changes. Keeping the ACL ID around somewhere should also be possible. I'll play around with that too. If it's for local debugging purposes though, it's totally possible to set up Hugo so the IDs would appear locally (with a "development flag" set), but not in production... but I'm not sure that's what you had in mind. I'll tune all these changes a bit before committing again, I want to make sure they look fine on all screen sizes first, but I should have something ready within the week. (So the ACL2019 crowd can profit from them. ;)) |
Yes, having this in place for ACL would be great. That will go live on the 28th, as you probably know. You have convinced me that adding the conference citation to the volume page would be too much. Maybe we could just add a full citation at the top of the individual paper pages. Not sure if you want to do that in this commit or not. |
Versions: I don't know why they should be shown in the listing. Paper ID: Never used the IDs on the listing, only the permanent URLs on the paper pages. Additional bonus: searching for the ID will only yield the paper site, not the listings. Distinguishing between additional material (green buttons) and other seems like a good idea; I like the two rows concept! Regarding the amount of buttons: Why does the anthology need a google search for the titles? The button is unintuitive (I would have guessed it does some internal search) and gives preference to a single search engine for no special reason. It is not even google scholar. It seems to me that we could live without that button. Re #412: The listing seem to be the wrong place for that, I like the clear delimiters using |. Page sizeThe pages are transferred as gzip anyway, so only about 1/8th of the size needs to be transferred. For the current ACL 2018 page, the html is 956kb, but only 126kb are transferred. (That is stil a surprising amount for the current site!) The papers are linked with the full https://www.aclweb.org/ prefix even though that is not necessary. Would save us some bytes. The hidden links with PDF extensions are on the event sites as well even though that is not needed. Changing that would introduce additional logic, right? |
This has been clarifying. I second everything @akoehn just wrote. |
+1 for Arne’s post too
On Tue, 16 Jul 2019 at 04:33, Matt Post ***@***.***> wrote:
This has been clarifying. I second everything @akoehn
<https://github.com/akoehn> just wrote.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#443?email_source=notifications&email_token=AABU725GW27SYI6OBTG6WVDP7TNKFA5CNFSM4H44IVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ64KHQ#issuecomment-511558942>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABU72Y4QRE5D2W46DS6B7LP7TNKFANCNFSM4H44IVOA>
.
--
- M
|
Thanks all, that has been very helpful! Regarding the Search button: I agree that it can be removed in the paper listings, but there's also a (big) Search button the pager pages. It currently searches on Google, but I always thought searching on Google Scholar would make much more sense. That could be used, e.g., to quickly search for preprint versions or find citations. If you agree, I'd change the Search button on the paper pages to Google Scholar instead (and maybe make that clear in the icon/text).
Yes, and I'm actually not sure how that could be done. For Hugo, each row in these listings is just a "view" of the paper pages, and AFAIK that view knows nothing about the context in which it's rendered. |
Maybe you could use the Agree with google scholar. |
Unfortunately not, the context is that of the page (= paper) being rendered, so The only thing we could do is move the invisible PDF link into its own template function, and call that separately in the templates where it should appear. It would appear in a different position then compared to now, but that's hopefully irrelevant? |
@mbollmann if it is not straight-forward, I would just postpone this issue. The change will be invisible to users, so no need to do this as part of this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice!
@mjpost: I'm currently building it and will have a look as well. Maybe let @mbollmann merge it, then he can decide whether he wants to do a squash- or a merge-commit. |
Sounds good. I'll leave it to you two to review further and merge. |
@mjpost Everything is well-aligned on my system, I can't reproduce your problem regarding spacing. Everything looks good to me, go ahead and merge! A small point which is not a blocker and could be dealt with separately as well (but it is a UI improvement): |
I agree that the banner seems dated at this point. It is however I think useful to have an easy way to report feedback. We've had several people click on that button and add some feedback to that long thread, and I suspect at least some of them may not have gone through the trouble of opening a new issue. Though it's hard to know. I do support removing it if that's the consensus. Which reminds me, it'd be nice to have an easy way to update the MOTD box without having to commit and rebuild... |
Seems that the badges are just a tiny bit wider on your system/browser. Maybe I can increase the minimum width just a tiny bit to compensate.
I would suggest moving the feedback button to the sidebar on the landing page. That way it's still at least somewhat prominent there. |
Merging this now, since I'll be offline without a laptop until Tuesday. I'm happy to push some fine-tuning changes (and do sth about the feedback banner) when I return. |
UI improvements: + Allow to see all co-authors and venues on people pages + Add abstracts to paper list entries + Change layout of buttons in paper list entries + Remove ACL IDs everywhere (except on paper detail pages) + Change search buttons to Google Scholar everywhere
This PR currently:
I would like some feedback on this, particularly on the following points:
Adding abstracts to all list pages (i.e., volumes and events) increases their file size substantially. For example, the event page for ACL 2018 is already at 626K, but grows to 1.1M with abstracts. Does the added functionality warrant having such large HTML files?
The button row before the paper title is getting quite crowded, especially with more and more additional material being accessible, e.g.:
Does anyone else feel this is a problem, or has an idea for how to make this nicer?