Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make URL canonical instead of PDF on paper page (closes #587) #622

Merged
merged 7 commits into from
Nov 14, 2019

Conversation

mjpost
Copy link
Member

@mjpost mjpost commented Nov 5, 2019

No description provided.

@mjpost mjpost requested a review from mbollmann November 5, 2019 16:34
@akoehn
Copy link
Member

akoehn commented Nov 12, 2019

This does not do the intended thing when compiling it on my machine, the result is this:

URL: Page(/papers/P/P19/P19-1001.md)

Does it work correctly on your machines?

hugo/layouts/papers/single.html Outdated Show resolved Hide resolved
@akoehn
Copy link
Member

akoehn commented Nov 13, 2019

Looks good to me now, but why did you put an additional border between DOI and PDF?
border
I see no relevant difference between the PDF and the other fields, so I would simply skip that border.

@mjpost
Copy link
Member Author

mjpost commented Nov 13, 2019

Yeah, it looks ugly. I was trying to separate data that's in the BibTex from other information about the paper. What about removing the border and putting the PDF line below the export formats line?

@aryamccarthy
Copy link
Member

I'd just keep it all together. The SIG info isn't in the BibTeX either.

@akoehn
Copy link
Member

akoehn commented Nov 13, 2019

agree with @aryamccarthy, this is an information block and not a bibtex information block. The volume ID is also not part of the bibtex.

Adding a line primarily makes people like me second-guess what the reason for the line could be :-)

@mjpost
Copy link
Member Author

mjpost commented Nov 13, 2019

Okay, I restored it. I moved the PDF link to the bottom because it's already extraneous and it looked ugly next to the URL line (since they're nearly identical in most cases).

@mjpost
Copy link
Member Author

mjpost commented Nov 13, 2019

Feel free to merge this if no one complains about me having moved it...:)

@akoehn
Copy link
Member

akoehn commented Nov 13, 2019

@mbollmann you requested changes therefore you need to approve before it can be merged.

@mbollmann mbollmann merged commit 0c9ba6a into master Nov 14, 2019
@mbollmann mbollmann deleted the pdf-link branch November 14, 2019 07:15
najtin pushed a commit to ir-anthology/ir-anthology that referenced this pull request Jun 9, 2021
…cl-org#622)

* make URL canonical instead of PDF (closes acl-org#587)

* class instead of hr

* fixed link

* removed DOI border, moved PDF to bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants