Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSearch Serverless request signing #88

Closed
Tracked by #44
dblock opened this issue Dec 9, 2022 · 0 comments · Fixed by #94
Closed
Tracked by #44

Support OpenSearch Serverless request signing #88

dblock opened this issue Dec 9, 2022 · 0 comments · Fixed by #94
Assignees

Comments

@dblock
Copy link
Collaborator

dblock commented Dec 9, 2022

Coming from opensearch-project/opensearch-java#287

Looks like we would need to add an option to skip content length.

@acm19 acm19 self-assigned this Dec 14, 2022
acm19 added a commit that referenced this issue Jan 6, 2023
Adds support for signing Serverless OpenSearch requests as described:
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/serverless-clients.html#serverless-signing.

Requirements:
* You must specify the service name as aoss.
* You can't include Content-Length as a signed header, otherwise you'll
get an invalid signature error.
* Uses Aws4Signer while serverless uses  Aws4UnsignedPayloadSigner.

Removes rule to have `final` for all parameters as it create verbose
code while not enforcing strong enough protection. All parameters are
consider immutable as a good practice anyway.

Resolves: #88
acm19 added a commit that referenced this issue Jan 8, 2023
Adds support for signing Serverless OpenSearch requests as described:
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/serverless-clients.html#serverless-signing.

Requirements:
* You must specify the service name as aoss.
* You can't include Content-Length as a signed header, otherwise you'll
get an invalid signature error.
* Uses Aws4Signer while serverless uses  Aws4UnsignedPayloadSigner.

Removes rule to have `final` for all parameters as it create verbose
code while not enforcing strong enough protection. All parameters are
consider immutable as a good practice anyway.

Resolves: #88
acm19 added a commit that referenced this issue Jan 8, 2023
Adds support for signing Serverless OpenSearch requests as described:
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/serverless-clients.html#serverless-signing.

Requirements:
* You must specify the service name as aoss.
* You can't include Content-Length as a signed header, otherwise you'll
get an invalid signature error.
* Uses Aws4Signer while serverless uses  Aws4UnsignedPayloadSigner.

Removes rule to have `final` for all parameters as it create verbose
code while not enforcing strong enough protection. All parameters are
consider immutable as a good practice anyway.

Resolves: #88
acm19 added a commit that referenced this issue Jan 8, 2023
Adds support for signing Serverless OpenSearch requests as described:
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/serverless-clients.html#serverless-signing.

Requirements:
* You must specify the service name as aoss.
* You can't include Content-Length as a signed header, otherwise you'll
get an invalid signature error.
* Uses Aws4Signer while serverless uses  Aws4UnsignedPayloadSigner.

Removes rule to have `final` for all parameters as it create verbose
code while not enforcing strong enough protection. All parameters are
consider immutable as a good practice anyway.

Resolves: #88
@acm19 acm19 closed this as completed in #94 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants