Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS API support for Nexcess, Thermo.io, and Futurehosting #1812

Closed
wants to merge 15 commits into from

Conversation

laszlof
Copy link
Contributor

@laszlof laszlof commented Aug 23, 2018

This adds DNS support for Nexcess, Futurehosting, and Thermo.io

All 3 use the same API backend (different endpoints), so the code is mostly identical other than the names of things.

@Neilpang
Copy link
Member

@laszlof
Copy link
Contributor Author

laszlof commented Aug 27, 2018

@Neilpang Thanks. I have read through the guide. Is there something specific I am missing from it?

@laszlof
Copy link
Contributor Author

laszlof commented Sep 6, 2018

@Neilpang is there anything additional that is needed on this PR?

@laszlof
Copy link
Contributor Author

laszlof commented Oct 18, 2018

Bumping this back up. Anything needed on my end @Neilpang?

@laszlof
Copy link
Contributor Author

laszlof commented Dec 14, 2018

Merge Conflicts Resolved.

@laszlof
Copy link
Contributor Author

laszlof commented Jan 21, 2019

Conflicts Resolved. (Again).

dnsapi/dns_fh.sh Outdated Show resolved Hide resolved
dnsapi/dns_fh.sh Outdated Show resolved Hide resolved
@Neilpang
Copy link
Member

https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

please make sure you can handle all the domains:

_acme-challenge.www.example.com
_acme-challenge.example.com
_acme-challenge.example.co.uk
_acme-challenge.www.example.co.uk
_acme-challenge.sub1.sub2.www.example.co.uk

And support v2 wildcard:
#1261

@laszlof
Copy link
Contributor Author

laszlof commented Jan 24, 2019

All issues have been corrected.

Also confirmed that it works with all example, including v2 wildcard.

@Neilpang
Copy link
Member

Sorry, I just noticed that you said these 3 apis are identical.
I wonder if we can use only script to handle all the 3 ?

export   XXX_AccessToken=xxxxxxx
export  XXX_Endpoint="https://my.futurehosting.com/"

acme.sh --issue  -d example.com  --dns  dns_xxx.sh 

We can save XXX_AccessToken and XXX_Endpoint

what do you think ?

@laszlof
Copy link
Contributor Author

laszlof commented Jan 25, 2019

@Neilpang Thats actually a good idea. I'll work out the details and update the PR

@laszlof
Copy link
Contributor Author

laszlof commented Jan 25, 2019

Do not merge yet. Still need to do some final testing.

@laszlof
Copy link
Contributor Author

laszlof commented Jan 30, 2019

@Neilpang This has been tested and should be good to go.

@Neilpang
Copy link
Member

Neilpang commented Feb 5, 2019

please close this PR, and make a new one.

Thanks.

@laszlof
Copy link
Contributor Author

laszlof commented Feb 6, 2019

Done. #2082

@laszlof laszlof closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants