Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnsapi] Support adding / removing multiple TXT values for Gandi #1994

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

drott
Copy link

@drott drott commented Dec 28, 2018

Gandi supports setting multiple entries by setting multiple array items
for the rrset_values field in their API. Modify the dns_gandi_livedns.sh
script so that it checks for existing entries, appends new ones if
needed, and removes existing ones individually. This enabled wildcard
certificate support on Gandi.

Fixes the dns_gandi_livedns part of #1261.

Tested by creating a multidomain, multiple wild-card certificate on
Gandi and using a test script executing only the dns_gandi_livedns_add
and dns_gandi_livedns_rm functions.

@drott
Copy link
Author

drott commented Dec 28, 2018

CC @fcrozat

@drott
Copy link
Author

drott commented Dec 28, 2018

The test script I was using for testing the add/rm functions individually was something like:

#!/usr/bin/env sh

. dns_gandi_livedns.sh
. ../acme.sh

DEBUG=2
GANDI_LIVEDNS_KEY=<removed>

#dns_gandi_livedns_add $1 $2
dns_gandi_livedns_rm $1 $2

@drott
Copy link
Author

drott commented Dec 28, 2018

Updated and shfmt'ed.

@drott
Copy link
Author

drott commented Dec 28, 2018

Fixed $_sub_domain vs $sub_domain issue, more formatting.

@Neilpang
Copy link
Member

please send PR to dev branch, instead of master.

Thanks.

@drott drott changed the base branch from master to dev December 29, 2018 08:53
Gandi supports setting multiple entries by setting multiple array items
for the rrset_values field in their API. Modify the dns_gandi_livedns.sh
script so that it checks for existing entries, appends new ones if
needed, and removes existing ones individually. This enabled wildcard
certificate support on Gandi.

Fixes the dns_gandi_livedns part of acmesh-official#1261.

Tested for creating a multidomain, multiple wild-card certificate on
Gandi and using a test script executing only the dns_gandi_livedns_add
and dns_gandi_livedns_rm functions.
@drott
Copy link
Author

drott commented Dec 29, 2018

please send PR to dev branch, instead of master.

Sure, sorry about that - I had seen the guidance in the commit msg and thought I had selected dev as base, but something must have slipped. Rebased on top of dev and base branch changed now.

@Neilpang
Copy link
Member

Neilpang commented Jan 3, 2019

thanks

@Neilpang Neilpang merged commit 83a0407 into acmesh-official:dev Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants