Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dns_doapi.sh #2053

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Added dns_doapi.sh #2053

merged 6 commits into from
Jan 25, 2019

Conversation

Manawyrm
Copy link
Contributor

Hi,

this new adapter adds support for the official LE API for the domain hosting company do.de.
There is already support in acme.sh in the dns_do.sh adapter, but this API has some downsides:

  • it's only available to business/enterprise customers
  • it requires you to save the full admin credentials (username/pw) in the server config of each machine
  • old API uses SOAP/XML and is marked for deprecation

The new API is explicitly meant to set _acme-challenge records and provides authentication via a token mechanism.
If you want to test this API, I will gladly send you a (test) token. Just tell me a mail address to send it to.

The plugin was written according to the dev guidelines and also supports wildcard certifiates.

PS: I'm not 100% sure about the naming, but I didn't want to break compatibilty with the existing API. Suggestions for a different filename are welcome.

Thanks,
Tobias

@Neilpang
Copy link
Member

please check every item of this guide:
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

and make sure your can handle v2 wildcard domain.
#1261

@Manawyrm
Copy link
Contributor Author

Manawyrm commented Jan 25, 2019

Apart from the fact that my name is dns_doapi.sh instead of doapi.sh (like it suggets in #2 of the guide), I think it follows all the guidelines.

It can handle v2 wildcard domains. I've successfully issued such a certificate.
dig screenshot

@Neilpang
Copy link
Member

I don't think so.

please make sure you can handle all the domains:

_acme-challenge.www.example.com
_acme-challenge.example.com
_acme-challenge.example.co.uk
_acme-challenge.www.example.co.uk
_acme-challenge.sub1.sub2.www.example.co.uk

please update your dns in the supported list:
https://github.com/Neilpang/acme.sh/tree/dev#8-automatic-dns-api-integration

@Manawyrm
Copy link
Contributor Author

Hi,

it can handle all these domains. The hoster API automatically handles that, and only needs to be provided with the FQDN.
It's a specialized LetsEncrypt API, build for this purpose.

The API is already on the supported list as "Domain-Offensive/Resellerinterface/Domainrobot API". Don't need to mention it twice.

@Neilpang
Copy link
Member

Ok,

please add it to the list still. So that the list count keep same as the count in the dnsapi readme.

60.  do.de API

In the dns api readme, please move to 60, not 59.

Thanks.

@Manawyrm
Copy link
Contributor Author

Manawyrm commented Jan 25, 2019

Sure, just did that :)

Thanks!

@Neilpang
Copy link
Member

OK.
please create a new issue: https://github.com/Neilpang/acme.sh/issues

Report bug to do.de dns api

And watch to that issue, if in future any bug is found, it will be reported there.

Thanks.

@Manawyrm
Copy link
Contributor Author

OK, created #2057 and followed the issue 😄

@Neilpang Neilpang merged commit 94922f2 into acmesh-official:dev Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants