Waveform widgets deprecation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all qt(old qglwidget based), gl and glsl waveform widgets
m0dB
force-pushed
the
restored-sw-waveforms
branch
from
5c8b63a
to
e113136
Compare
This was referenced May 22, 2024
Pull Request Test Coverage Report for Build 9198301223Details
💛 - Coveralls |
acolombier
merged commit 5e12b2c
into
acolombier:feat/simplify-waveform-combobox
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored the software renderering (qpainter, non-opengl) waveforms, also on macOS.
Moved GL (non-shader) and Qt (polygon-based) to deprecated.
This leaves us with the allshader (OpenGL GLSL based) and software rendering (QPainter based) waveform types.
Note that simple and stacked are missing for the software rendering (QPainter based) waveform types.