This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Join Channel on text field and use the Chat icon for selecting chat #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal that change the behavior of the Channel Row. The Join arrow is removed and a chat bubble is added instead. So now you press the text of the channel to join it (cvh.itemView.setOnClickListener), and the Chat bubble to join the Chat channel. If someone want a more safe join channel, an option in seeting called something like "safe join channel" could be added, and a long press would be needed (cvh.itenView.senOnLongClickListener joins channel instead of opening the moreMenu)
|
This is how it looks: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal that change the behavior of the Channel Row.
The Join arrow is removed and a chat bubble is added instead.
So now you press the text of the channel to join it (cvh.itemView.setOnClickListener), and press the Chat bubble to join the Chat channel.
If someone want a more safe join channel, an option in settings->general called something like "safe join channel" could be added, that sets long press click on text to join channel, and short channel click does nothing. (cvh.itenView.senOnLongClickListener joins channel instead of opening the moreMenu)
I´ll gladly incorporate that if wished by someone.
The setOnClickListener is moved down to the other actions so all Channel actions are the same place.
The ChannelRow text are set to 18sp and made Bold so there´s a clear difference between channels and users.
The PushToTalk label are also set to 18sp and made Red.