This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Fix for JoinChannel scrolls channel list to button Issue#178 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(e.g. use public server Libre Antenne) Using the release candidate from Fdroid 3.3.0rc1: When joining a channel on a larger server the display scrolls to another place on the list. So it can be hard to find the group you joined. The version 3.2.0 in playstore (with the old JoinChannel function) does not have this issue. Changing mChannelView.smoothScrollToPosition to mChannelView.scrollToPosition (in ChannelListFragment.java->scrollToChannel) solves the problem. Are there any reasons for using the smoothScrollToPosition instead og scrollToPosition? and do you think it´s because of a certain SDK version? Otherwise I propose to change it.
|
3q |
|
I'm alright with this change, but I'd like to know the reason why switching to scrollToPosition intead of smoothScrollToPosition fixes the problem (it could be that scrollToPosition's immediacy covers up the underlying root problem here). Is there any interesting logging done when the scroll overshoot happens? |
|
I´ll look into it, next week, and see what I can find. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. use public server Libre Antenne)
Using the release candidate from Fdroid 3.3.0rc1:
When joining a channel on a larger server the display scrolls to another place on the list.
So it can be hard to find the group you joined.
The version 3.2.0 in playstore (with the old JoinChannel function) does not have this issue.
Changing mChannelView.smoothScrollToPosition to mChannelView.scrollToPosition (in ChannelListFragment.java->scrollToChannel) solves the problem.
Are there any reasons for using the smoothScrollToPosition instead og scrollToPosition? and do you think it´s because of a certain SDK version?
Otherwise I propose to change it.