Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naming profiles after account alias or number #2

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

acoppolawb
Copy link
Owner

@acoppolawb acoppolawb commented Aug 12, 2021

Functionally a copy of Nike-Inc#294

Description

In many orgs (like mine) we use a single role in multiple accounts, and we name our aws profiles after the account name.

Related Issue

Resolves Nike-Inc#293

Motivation and Context

We have a lot of AWS accounts, and their names are long enough - using the roles makes it hard to use the cli with the resulting credentials.

How Has This Been Tested?

Added UT

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@acoppolawb acoppolawb changed the title Copy of: https://github.com/Nike-Inc/gimme-aws-creds/pull/294 Support naming profiles after account alias or number Aug 12, 2021
@acoppolawb acoppolawb merged commit a60b474 into master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating AWS profile named according to the AWS account alias / number
1 participant