Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: ES2025 RegExp Duplicate named capturing groups #1290

Closed
ota-meshi opened this issue Apr 13, 2024 · 6 comments
Closed

Feature Request: ES2025 RegExp Duplicate named capturing groups #1290

ota-meshi opened this issue Apr 13, 2024 · 6 comments

Comments

@ota-meshi
Copy link
Contributor

ota-meshi commented Apr 13, 2024 •
edited
Loading

RegExp Duplicate named capturing groups has now reached stage 4. I would like Acorn to support the new syntax.

https://github.com/tc39/proposal-duplicate-named-capturing-groups
tc39/ecma262#2721
This was referenced Apr 13, 2024
Closed
Closed
@marijnh
Copy link
Member

marijnh commented Apr 15, 2024

Where does it say this reached stage 4? The repository's readme still has it at 3.

@ota-meshi
Copy link
Contributor Author

I think it has reached stage 4. Listed as ES2025.

https://github.com/tc39/proposals/blob/main/finished-proposals.md

image

marijnh added a commit that referenced this issue Apr 16, 2024
@marijnh
Allow duplicate regexp capture group names in different branches
79dea8b 
FEATURE: Support ES2025 duplicate capture group names in regular
expressions.

Issue #1290
Issue #1291
marijnh added a commit that referenced this issue Apr 16, 2024
@marijnh
Allow duplicate regexp capture group names in different branches
7b7c1cd 
FEATURE: Support ES2025 duplicate capture group names in regular
expressions.

Issue #1290
Issue #1291
marijnh added a commit that referenced this issue Apr 17, 2024
@marijnh
Allow duplicate regexp capture group names in different branches
9d041c4 
FEATURE: Support ES2025 duplicate capture group names in regular
expressions.

Issue #1290
Issue #1291
@marijnh
Copy link
Member

marijnh commented Apr 17, 2024

Done in 9d041c4

@marijnh marijnh closed this as completed Apr 17, 2024
@ota-meshi
Copy link
Contributor Author

Hi marijnh.
Are there plans to release this feature?

@marijnh
Copy link
Member

marijnh commented Jun 14, 2024

I've tagged 8.12.0 with this

@ota-meshi
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ES2025 RegExp duplicate named capturing groups ota-meshi/acorn
2 participants
@marijnh @ota-meshi