Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit Drush test should use the actual local URL #12

Closed
danepowell opened this issue May 2, 2016 · 3 comments
Closed

PHPUnit Drush test should use the actual local URL #12

danepowell opened this issue May 2, 2016 · 3 comments

Comments

@danepowell
Copy link
Contributor

DrushTest currently looks for a hardcoded local URL, 127.0.0.1:8888: https://github.com/acquia/bolt/blob/8.x/template/tests/phpunit/DrushTest.php

Seems like it should be looking for the project-specific URL or something else entirely. This fails on our project.
@geerlingguy
Copy link
Contributor

Agreed; this will break when using Drupal VM too.

@ba66e77
Copy link
Contributor

ba66e77 commented Jun 1, 2016

The behat uses a local url variable to (I believe) identify the url that should be used. Seems like that should also work for the Drush test.

grasmash added a commit to grasmash/bolt that referenced this issue Jun 6, 2016
@grasmash
Resolves acquia#12: Use local uri in DrushTest
ced37b2
@danepowell
Copy link
Contributor Author

I'm pretty sure this was fixed by #122, if not please re-open.

@mikemadison13 mikemadison13 mentioned this issue Nov 14, 2016
Closed
@jestinijames jestinijames mentioned this issue Jun 9, 2017
Closed
@vishakha-s vishakha-s mentioned this issue Jan 8, 2018
Closed
@jedgar1mx jedgar1mx mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@geerlingguy @ba66e77 @danepowell