Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleSAMLphp config files not included in deploy artifact #506

Closed
dooleymatt opened this issue Oct 6, 2016 · 0 comments
Closed

SimpleSAMLphp config files not included in deploy artifact #506

dooleymatt opened this issue Oct 6, 2016 · 0 comments

Comments

@dooleymatt
Copy link
Contributor

Problem/motivation

  1. When blt simplesamlphp:init the simplesamlphp.settings.php file gets copied into the vendor/acquia/blt/settings directory.
  2. When blt deploy ... is run, it checks for the existence of that settings file in vendor/acquia/blt/settings and if it exists, simplesamlphp:deploy:config is called, which copies the config files into the vendor directory

The problem is that since simplesamlphp:init isn't run when the deploy artifact dependencies are being built, the settings file doesn't get created in the deploy artifact's vendor directory, and as a result simplesamlphp:deploy:config doesn't get called.

Proposed resolution

When blt simplesamlphp:init is run it needs to modify something outside the vendor directory which can be checked during blt deploy:build. However the only modifications that are made outside the vendor directory are modifications that have a high likelihood of being changes that would be made by a simplesaml installation that wasn't initiated by BLT.

So it seems to me that the logical thing to do would be to set a property inside the project.yml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant