Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud hooks for ACSF #1209

Merged
merged 6 commits into from
Mar 20, 2017
Merged

Add Cloud hooks for ACSF #1209

merged 6 commits into from
Mar 20, 2017

Conversation

lcatlett
Copy link
Contributor

Fixes #853

Changes proposed:

  • Provides Cloud Hooks support on ACSF for BLT deploy and setup tasks by looping through available site uris on the factory.
  • Enables cloud hooks on ACSF by default for post-code-update and post-code-deploy hooks.
  • Allows for managing ACSF environment, cm, and deployment config via project.yml
  • Adds a drush utility which is already in use on many ACSF projects. It provides commands to get information about Factory sites and enables running drush commands against all sites on a Factory.
  • The acsf-tools-ml command requires the user to confirm with 'ok' as it assumes that you are SSHed into the Factory and manually running drush commands which is discouraged since those changes are not tracked in VCS and likely not tested.

To give some background, the method that cloud hooks functionality has previously been enabled on ACSF projects is via a modified version of the acsf-tools-ml command which removed the 'ok' confirmation requirement, but this only allowed for running single drush commands against all sites and there was no integration with the BLT deploy and setup tasks. This required manually re-writing the deploy and setup tasks into a separate script and there was no support for tasks managed via project.yml such as toggle-modules, etc. This PR adds full support for BLT deploys to ACSF to mirror the ACE deployment process. It is enabled by default for new projects and can be added to existing projects by modifying the ACSF exclusion in the post-code-deploy and post-code-update hooks. In the future, it may make sense to exclude running the deploy updates on the 01devup, 01testup, and 01update environments in the post-code-update hook, as site databases are only synced to these environments on Factory code deploys.

@grasmash grasmash added the Enhancement A feature or feature request label Mar 19, 2017
@grasmash grasmash changed the title Blt 853 acsf hooks Add Cloud hooks for ACSF Mar 19, 2017
@grasmash
Copy link
Contributor

@lcatlett wow this looks great! Have you tested this on a real site?

@lcatlett
Copy link
Contributor Author

@grasmash I have only tested this for one project but would be happy to help out with testing on other projects

@grasmash grasmash merged commit e75d45b into acquia:8.x Mar 20, 2017
@lcatlett lcatlett deleted the blt-853-acsf-hooks branch November 10, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants