Refactor drush task #1460
Merged
Refactor drush task #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
reviewed
May 2, 2017
src/Robo/Tasks/DrushTask.php
Outdated
| * @return $this | ||
| */ | ||
| public function globalOption($option, $value = null) { | ||
| if ($option !== null and strpos($option, '-') !== 0) { |
There was a problem hiding this comment.
I don't totally understand why it's necessary to override parent::option and also have a separate globalOption method. Can you explain and perhaps add a comment to the code with the explanation?
malikkotob
force-pushed
the
refactor-drush-task
branch
2 times, most recently
from
18e83dd
to
27fe07f
Compare
malikkotob
force-pushed
the
refactor-drush-task
branch
from
27fe07f
to
d143d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.