Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal libraries path in composer install should match .gitignore #1563

Closed
wants to merge 1 commit into from
Closed

Drupal libraries path in composer install should match .gitignore #1563

wants to merge 1 commit into from

Conversation

danielnitschelc
Copy link

It seems to me these should be the same.

This pull request updates the libraries path in composer.json to match .gitignore.

@danielnitschelc danielnitschelc changed the title Drupal libraries path in composer install path should match .gitignore Drupal libraries path in composer install should match .gitignore Jun 1, 2017
@grasmash grasmash added the Bug Something isn't working label Jun 1, 2017
@greylabel
Copy link
Contributor

greylabel commented Jun 1, 2017

The composer path should not change, IMO. You can always specify /contrib as the installer path in your individual library definition if there is a need for that.

@danielnitschelc
Copy link
Author

@greylabel do you think the .gitignore should be changed then?

@greylabel
Copy link
Contributor

@danielnitschelc maybe adding docroot/libraries to .gitignore makes the most sense. I can't think of any contrib modules that actually want for libraries in docroot/libraries/contrib. Webform, for example, expects libraries to be placed directly in docroot/libraries

@grasmash
Copy link
Contributor

grasmash commented Jun 5, 2017

maybe adding docroot/libraries to .gitignore makes the most sense.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants