Adding support for custom commands in frontend and setup targets. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # E.g., ${docroot}/sites/all/themes/custom/mytheme. | ||
| dir: ${docroot} | ||
| # E.g., `npm install` or `bower install`. | ||
| command: echo 'Hello world!' |
There was a problem hiding this comment.
I'm not crazy about "Hello world" here.
I think it could be confusing to see it go past during a build, out of context.
I'd rather see something like echo 'Frontend build not configured.
| <foreach list="${project.themes}" param="frontend.theme" target="frontend:build:run"/> | ||
| </then> | ||
| </if> | ||
| <target name="frontend:build" description="Uses gulp to build front end dependencies for all themes."> |
There was a problem hiding this comment.
The description here feels a bit misleading to me. As a user I might expect there to already be some magic built in to find and compile my sass files with gulp. It's not clear by the description that I would need to define the command in my project.yml file. Unless I'm missing something which very well could be the case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.