Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore custom theme node_modules folder #203

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Conversation

justinlevi
Copy link
Contributor

No description provided.

@grasmash
Copy link
Contributor

Any reason not to simply ignore node_modules altogether?

@justinlevi
Copy link
Contributor Author

@grasmash good point. I'm wondering if it's a bit heavy handed to ignore node_modules and bower_components from the root .gitignore file? Would it be better to let the user enforce that in their own theme or is it beneficial for people who might forget, etc?

@grasmash
Copy link
Contributor

Given that "not committing external dependencies" is one of the core architectural principles of BLT, so I think we can be heavy handed in this case. People can always choose to customize the .gitignore file at the root.

@grasmash grasmash merged commit 3ddf1fa into acquia:8.x Aug 3, 2016
@justinlevi justinlevi deleted the patch-5 branch March 17, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants