Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vendor name configurable. #68

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Make vendor name configurable. #68

merged 1 commit into from
Jun 6, 2016

Conversation

greylabel
Copy link
Contributor

No description provided.

@greylabel
Copy link
Contributor Author

@grasmash -- can you kick Travis to test this again?

@grasmash
Copy link
Contributor

grasmash commented May 27, 2016

I'm tempted to just replace the "acquia" in the template/composer.json with "your-organization". It's the only place that the variable would be used, so should we really make it a variable? Thoughts?

@grasmash
Copy link
Contributor

Test has been kicked off again.

@greylabel
Copy link
Contributor Author

@grasmash I agree this is a pretty trivial change, on the surface. I think the crux of the issue is whether we leverage a single file to hold project-specific config (project.yml), or if we are ok with config/variables/etc being spread throughout the BLT code and potentially undocumented. Personally, I would favor a more robust project.yml rather than need to make project-specific changes throughout the codebase.

@grasmash grasmash merged commit d6b6e60 into acquia:8.x Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants