Updating template/composer.json to use Drupal packagist constraints. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
grasmash
force-pushed
the
issue-759-lightning-packagist
branch
from
e8f6d95
to
acc664d
Compare
grasmash
commented
Dec 8, 2016
| // 8.1.0-alpha1 > 1.0.0-alpha1 | ||
| // 8.1.0-beta12 > 1.0.0-beta12 | ||
| // 8.12.0-rc22 > 12.0.0-rc22 | ||
| if (preg_match('/^([\^~])?8(\.)?(\d+)?(\.\d+)?(-(alpha|beta|rc)\d+)?(\.\*)?(@(dev|alpha|beta|rc))?/', $version_constraint, $matches)) { |
There was a problem hiding this comment.
Need to also cover refs and "dev-" prefixes.
There was a problem hiding this comment.
Need to support more operators:
https://getcomposer.org/doc/articles/versions.md#range
phenaproxima
reviewed
Dec 8, 2016
|
|
||
| // dev-master => master-dev | ||
| // dev-something#123abc => something-dev#123abc | ||
| if (preg_match('/^dev-([A-Za-z0-9-]+)(#[0-9a-f]+)?/', $version_constraint, $matches)) { |
There was a problem hiding this comment.
This doesn't account for the possibility of underscores in the branch name.
phenaproxima
reviewed
Dec 8, 2016
| function convert_version_constraint($version_constraint) { | ||
|
|
||
| // 8.* => * | ||
| if (preg_match('/8\.\*$/', $version_constraint)) { |
There was a problem hiding this comment.
There's no anchor at the beginning, so won't this also match something like 1.8.*?
|
We ended up tweaking the output for branches a little bit to:
See here: https://github.com/acquia/lightning/blob/8.x-1.x/src/UpgradeBuild.php |
grasmash
force-pushed
the
issue-759-lightning-packagist
branch
from
1f604de
to
677f305
Compare
…gist constraints.
grasmash
force-pushed
the
issue-759-lightning-packagist
branch
from
677f305
to
11f7737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.