Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #796: Don't exclude local.* files from build artifact. #797

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Fixes #796: Don't exclude local.* files from build artifact. #797

merged 1 commit into from
Dec 14, 2016

Conversation

geerlingguy
Copy link
Contributor

Fixes #796 .

Changes proposed:

  • Don't exclude local.* from default gitignore template for build artifacts.
  • Don't exclude local.* files from default deploy-exclude.txt file.

@grasmash
Copy link
Contributor

We still need to exclude local.settings.php

@geerlingguy
Copy link
Contributor Author

@grasmash ah, good catch. I'll add that as a separate line then, if that's okay.

@geerlingguy
Copy link
Contributor Author

PR has been updated. I tested with one of my codebases, and it seems to exclude the settings file correctly (but not the default/example one).

@grasmash grasmash added the Enhancement A feature or feature request label Dec 14, 2016
@grasmash grasmash merged commit 65fb895 into acquia:8.x Dec 14, 2016
@geerlingguy geerlingguy mentioned this pull request Dec 20, 2016
Closed
@danepowell danepowell mentioned this pull request Jan 4, 2017
Merged
@timcosgrove timcosgrove mentioned this pull request Jan 4, 2017
Merged
@geerlingguy geerlingguy deleted the fix-gitignore-local branch March 21, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geerlingguy @grasmash