Migrate from Travis CI to GitHub Actions #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really need to move since this is OSS? |
grasmash
reviewed
Sep 10, 2021
| @@ -0,0 +1,73 @@ | |||
| name: CI | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
are the trailing colons necessary here?
There was a problem hiding this comment.
Trailing colon is required, since it's a mapping, not a simple list/array. Docs explicitly say so
You must append a colon (:) to all events, including events without configuration
grasmash
reviewed
Sep 10, 2021
grasmash
reviewed
Sep 10, 2021
Yes. You'll see the ticket in the backlog shortly with more details, but this is mandatory. |
|
@grasmash The upstream action was approved, so this can be merged whenever you're comfortable with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working and ready for review.
softprops/action-gh-release@v1is approved and enabled on the org.Until this is merged, it won't actually run on the Acquia account. You can see test results for this feature branch on my fork: https://github.com/danepowell/cli/actions
You can also see a tagged release where Actions attached the phar: https://github.com/danepowell/cli/releases/tag/actions1