Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert wECO mainnet to a dummy address #9

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Nov 10, 2023

There are utility functions that iterate over the array of TOKEN_SYMBOLS_MAP values and return the first symbol matching an address for a particular chain ID. If chainIds are reused in this way, the ordering of TOKEN_SYMBOLS_MAP determines which symbol would be returned. This is generally undesirable, so avoid reusing token addresses in this way.

There are utility functions that iterate over the array of
TOKEN_SYMBOLS_MAP values and return the first symbol matching an address
for a particular chain ID. If chainIds are reused in this way, the
ordering of TOKEN_SYMBOLS_MAP determines which symbol would be returned.
This is generally undesirable, so avoid reusing token addresses in this
way.
@pxrl pxrl merged commit e0327ae into master Nov 10, 2023
@pxrl pxrl deleted the pxrl/wECOMainnet branch November 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants