Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relayer): Add viem-based external SpokePool listener #1842

Merged
merged 15 commits into from
Sep 30, 2024

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Sep 26, 2024

viem supports keepalives and timeouts on websocket transports. In testing it has appeared to successfully websocket connections for longer than ethers v5.

This is a pre-emptive change made to make it easier to reuse common
components in alternative listener implementations. Examples for a
viem-based listener, as well as an eventual Solana listener.
viem supports keepalives and timeouts on websocket transports. In
testing it has appeared to successfully websocket connections for longer
than ethers v5.
@pxrl pxrl requested a review from bmzig September 26, 2024 22:22
Base automatically changed from pxrl/listenerFactor to master September 30, 2024 12:44
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question - otherwise looks good

@pxrl pxrl merged commit 560abc0 into master Sep 30, 2024
4 checks passed
@pxrl pxrl deleted the pxrl/viemListener branch September 30, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants