-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Transcript Rules #2064
base: develop
Are you sure you want to change the base?
Conversation
Are being updated from Task force feedback
Adding applicable updates from the TF feedback on audio transcripts
Co-authored-by: Jean-Yves Moyen <[email protected]>
Discussed at the TF meeting 29 Feb |
Updating the rules after a taskforce discussion
Updates from the taskforce meeting
Updated to match the task force amendments
I have made updates to hopefully resolve the feedback you had!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not super happy with the inclusion in the accessibility tree part 😅
From the TF discussion, I think I understand that TF reached the consensus that an inaccessible transcript is not always a 1.2.1 failure.
If this is indeed the case, then yes, we need to remove it (and the corresponding Failed Example). But in this case I'd like us to have a Passed example with an accessible transcript that is not failing 1.2.1. This will serve as documentation of this decision and essentially say: "no, inclusion in the accessibility tree is not required, look at this". (and if people disagree with this decision in the future, we'll have the example to foster concrete discussions instead of doing archaeology in Github history.
If I'm reading that wrong and that the issue with inaccessible transcripts is that they fail both 1.2.1 and 1.3.1, then I think that a better solution would be to add 1.3.1 as a related secondary requirement; this is similar to the secondary requirement to 1.1.1 for "link have accessible name" (due to area
elements)
Amended the updated of unmuted as the term is not recognised so used "not mute" instead.
As actioned
Co-authored-by: Kathy Eng <[email protected]>
I couldn't add this in my review comments - Like the change you made in 2eb176, please change this failed example 4 to passed example 3 in ee13b5. Failed Example 4This <html lang="en">
<video controls>
<source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4"></source>
<source src="/test-assets/rabbit-video/silent.webm" type="video/webm"></source>
</video>
<p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground.
He stretches, yawns, and then starts walking.
Then he stops to scratch his bottom.</p>
</html> |
Co-authored-by: Kathy Eng <[email protected]>
Co-authored-by: Kathy Eng <[email protected]>
Co-authored-by: Kathy Eng <[email protected]>
Moved a failed to a passed and added a secondary 1.3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about the autoplay attribute
|
||
- playing; or, | ||
- has a [play button][] that is [visible][] and [included in the accessibility tree][]. | ||
- the element has an [autoplay][] [attribute value][] of `true`; or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.
@@ -81,7 +88,7 @@ This `audio` element has native player controls and an external transcript. | |||
|
|||
#### Passed Example 3 | |||
|
|||
This `audio` element has an `autoplay` attribute and an external transcript. | |||
This `audio` element has an [autoplay][] attribute and an external transcript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.
@@ -131,7 +154,7 @@ This `audio` element has native player controls and an incorrect external transc | |||
|
|||
#### Failed Example 4 | |||
|
|||
This `audio` element has an `autoplay` attribute and an incorrect external transcript. | |||
This `audio` element has an [autoplay][] attribute and an incorrect external transcript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.
|
||
## Accessibility Support | ||
|
||
There are no accessibility support issues known. | ||
|
||
## Background | ||
|
||
Some major browsers do not automatically play the 'video' unless it is muted, which makes the rule inapplicable in these browsers. The rule still applies to browsers that [autoplay][] an audible 'video'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should link to the autoplay definition, but since it is being used in the Background section, the definition doesn't need to be objective.
Are being updated from Task force feedback
Amending the rule from TF feedback: https://docs.google.com/spreadsheets/d/1OSkPFocXk4K3zYLnwS78WLsWO4PvE5yRcsauyefuIUI/edit#gid=1605073031
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review
How to Review And Approve