Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added text-shadow failure - Text has minimum contrast [afw4f7] #2184

Merged

Conversation

giacomo-petri
Copy link
Collaborator

Closes: #2172

Often, there's a misunderstanding that including a text-shadow property automatically ensures that text will have a satisfactory contrast ratio with its background.
To dispel this notion, I've provided an example where the text-shadow property fails to guarantee adequate contrast, contrasting with the Passed Example 4, to emphasize that relying solely on text-shadow doesn't always ensure sufficient contrast.

Need for Call for Review:
This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@giacomo-petri giacomo-petri self-assigned this Apr 24, 2024
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked this over with Carlos earlier this week. I think a better example here would be one that shows text-shadow actually creating a failure, rather than one where text-shadow can be ignored.

_rules/text-contrast-afw4f7.md Outdated Show resolved Hide resolved
@giacomo-petri giacomo-petri added the Review call 2 weeks Call for review for new rules and big changes label Aug 1, 2024
@giacomo-petri
Copy link
Collaborator Author

2 weeks call for review ends on August 16th.

@WilcoFiers WilcoFiers merged commit b4663d2 into develop Aug 30, 2024
2 checks passed
@WilcoFiers WilcoFiers deleted the giacomo-petri-minimum-contrast-text-shadow-failure branch August 30, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review call 2 weeks Call for review for new rules and big changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text-shadow failure - Text has minimum contrast [afw4f7]
6 participants