-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule: Summary element has non-empty accessible name #2202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An inapplicable example for two summary elements to catch the third applicability bullet would be useful.
Co-authored-by: Tom Brunet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍
Co-authored-by: Jean-Yves Moyen <[email protected]>
Couple tweaks, please have another look
Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Giacomo Petri <[email protected]>
Co-authored-by: Giacomo Petri <[email protected]>
In Firefox, the ::marker CSS pseudo-element is part of the accessibility tree, which means the accessible name cannot be left empty in Firefox. Should we address this, clarifying that the "triangle" icon is not enough? |
|
||
## Accessibility Support | ||
|
||
Implementation of [Presentational Roles Conflict Resolution][] varies from one browser or assistive technology to another. Depending on this, some elements can have a [semantic role][] of `button` and fail this rule with some technology but users of other technologies would not experience any accessibility issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would the element having a semantic role of button make it fail this rule? Is this copy/paste from another rule?
</details> | ||
``` | ||
|
||
### Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add failed example with two summary elements, being the first empty
Co-authored-by: Jean-Yves Moyen <[email protected]>
New rule to test that summary elements have an accessible name.
I don't think this is covered by any other rule today, since summary elements do not have a semantic role.
Need for Call for Review: 2 weeks
How to Review And Approve