Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous filter #20

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove superfluous filter #20

merged 1 commit into from
Dec 21, 2023

Conversation

rouzbeh
Copy link
Contributor

@rouzbeh rouzbeh commented Dec 20, 2023

No description provided.

@rouzbeh rouzbeh added the bug Something isn't working label Dec 20, 2023
@rouzbeh rouzbeh self-assigned this Dec 20, 2023
dgerstel
dgerstel approved these changes Dec 20, 2023
View reviewed changes
Copy link

@dgerstel dgerstel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouzbeh
I understand MNE provides a filter already, so it can be removed?

@rouzbeh rouzbeh merged commit fdf97c6 into main Dec 21, 2023
5 checks passed
@rouzbeh rouzbeh deleted the man/too_much_filtering branch January 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerstel dgerstel dgerstel approved these changes

Assignees

@rouzbeh rouzbeh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouzbeh @dgerstel