Add working-directory #59
Conversation
|
Works great for me! https://github.com/fenollp/reMarkable-tools/runs/637142119?check_suite_focus=true |
|
Hey guys, any plans to accept this pr? |
|
This would be nice to have! |
The GitHub Actions recipe is using a fork of `actions-rs/cargo` which includes this PR to support a `working-directory` attribute: actions-rs/cargo#59 Ideally `actions-rs/cargo` will eventually merge this PR.
The GitHub Actions recipe is using a fork of `actions-rs/cargo` which includes this PR to support a `working-directory` attribute: actions-rs/cargo#59 Ideally `actions-rs/cargo` will eventually merge this PR.
|
Why hasn't this been merged yet? GH hasn't added support for |
| @@ -10,6 +10,7 @@ import stringArgv from "string-argv"; | |||
| export interface Input { | |||
| command: string; | |||
| toolchain?: string; | |||
| "working-directory"?: string; | |||
There was a problem hiding this comment.
workingDirectory to be consistent with useCross
There was a problem hiding this comment.
Maybe. But in all other cases of working directory usage in GH actions (and especially run), it’s used as “working-directory”. So this is consistent with the GH action ecosystem.
There was a problem hiding this comment.
@MarcoPolo I think working-directory is a good name in YAML but not in JS. For example, the GitHub official action, actions/checkout has input named ssh-key but the name in JS is sshKey.
So I think you should use workingDirectory in JS as @VincentLanglet suggested.
|
Any updates for this PR? |
|
This repo is dead |
|
Any updates on this PR? What's stopping it from being merged? |
|
The only maintainer of the @actions-rs organization, @svartalf, has been known to take protracted absences from the internet. Feel free to fork the project in @svartalf's absence. |
|
Hi, everyone. I'm well aware that this PR is quite stale, but at the moment I do not have neither resources nor time to maintain any of my open source projects. Hopefully there will be more time available for me closer to this spring, but not right now because my personal matters and well-being of me and my family are more important for me. Before you ask about adding more maintainers, I thought about it for a long time, but since @actions-rs are used heavily both by companies and individuals at this point for both public and private repos, there is a huge trust issue we should take into the consideration, because having a write access to these repositories provides a huge attack vector too. I do hope that I'll be able to get back to these repos some time soon. P.S. Dear @fanninpm , I can't say I'm appreciating your negative implication in here
I suggest you to re-consider your position on this topic and start behaving yourself; I do not own you anything (as a reminder, it is also explicitly stated in the project license) and how exactly I'm maintaining my projects or what spending my time on is also none of your business. |
Using @MarcoPolo action-rs cargo fork until hopefully actions-rs/cargo#59 gets merged. Signed-off-by: Samuel Ortiz <[email protected]>
Using @MarcoPolo action-rs cargo fork until hopefully actions-rs/cargo#59 gets merged. Signed-off-by: Samuel Ortiz <[email protected]>
|
Use this one instead: |
Fixes #6.
I wish this would be handled in the Github Actions Framework level. It seems silly that all actions are expected to provide something like this.
Prior Art:
(Other actions also add this option.
working-dirworks withrunI recommend rebuilding this before publishing as a security best practice.