revise adr to support fetch-refs #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/m166refs
branch
from
51176b6
to
8c9b201
Compare
ericsciple
commented
Feb 13, 2020
| @@ -43,12 +43,18 @@ We want to take this opportunity to make behavioral changes, from v1. This docum | |||
| fetch-depth: | |||
| description: 'Number of commits to fetch. 0 indicates all history.' | |||
| default: 1 | |||
| fetch-refs: | |||
There was a problem hiding this comment.
Opted to update existing ADR rather than create a new document. This single file gives a holistic picture.
This was referenced Feb 18, 2020
Closed
chrispat
approved these changes
Mar 12, 2020
This was referenced Apr 15, 2020
|
Would be great to see this merged in. Any update on this? |
|
Any update on this? |
|
It is really bad this PR is hanging for so long This is a must have for all people using |
|
@ericsciple any updates on this? |
|
Did this ever get anywhere? @chrispat |
|
@ericsciple @chrispat bump. It would be really nice to have this! |
|
I am going to close this as there are no plans to add this feature at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose adding a new input
fetch-refsto specify additional refs to fetch.Customers commonly want to fetch additional branches or tags. This has come up in issues and the docs have improved to provide guidance (add additional
runstep).Given how common these scenarios are, we should provide a first-class input.
Another common scenario is to compare code coverage numbers between the PR merge commit, and the PR base branch.