-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @actions/github for rest calls instead of axios #63
Conversation
@JamesMGreene You seem to have the most contrib in this repo and the deploy-pages one, where I have proxy-related PRs for both. Any chance you can give these a look? This is the deploy-pages one: actions/deploy-pages#111 |
@daleyjem The idea seems sound, though it looks like a few more changes might be necessary. I'll try to get this merged today or tomorrow! 👀 |
Thanks @JamesMGreene. Just pushed up the prettier fix. |
@jeremy-daley-kr After some tweaks on our side, I've merged this and released it as Thanks again for the PR! 💝 |
@JamesMGreene Appears to have worked! Thanks! FWIW... I added another comment on the deploy-pages PR. Also, sorry about the confusion of different Github users... I started this stuff on my work machine 😬 |
Seems better to use Github's JS packages to do REST calls rather than manually constructing
axios
requests. Plus it fixes potential proxy issues (currently happening with use ofaxios
) for organizations using self-hosted runners.