Skip to content

Commit

Permalink
Merge pull request #116 from actions/unknown-licenses
Browse files Browse the repository at this point in the history
Unknown licenses
  • Loading branch information
febuiles authored Jun 15, 2022
2 parents 43ce5df + c0d3293 commit 981c44c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/licenses.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export function getDeniedLicenseChanges(

for (const change of changes) {
let license = change.license
// TODO: be loud about unknown licenses
if (license === null) {
unknown.push(change)
continue
Expand Down
3 changes: 2 additions & 1 deletion src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,11 @@ async function run(): Promise<void> {

if (licenseErrors.length > 0) {
printLicensesError(licenseErrors, licenses)
printNullLicenses(unknownLicenses)
core.setFailed('Dependency review detected incompatible licenses.')
}

printNullLicenses(unknownLicenses)

if (failed) {
core.setFailed('Dependency review detected vulnerable packages.')
} else {
Expand Down

0 comments on commit 981c44c

Please sign in to comment.