Update HTTPEventSourceListener to trace the right events. #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Aug 1, 2023
Comment on lines
-359
to
-360
| "Enter", | ||
| "Exit" |
There was a problem hiding this comment.
these 2 events no longer exists in the newer version dotnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotnet core changed their network tracing event source name as part of dotnet core 5.0
dotnet/runtime#37428
We need to react these changes otherwise we are not going to get any trace from the network layer from dotnet core.
TLDR:
Microsoft-System-Net-Http->System.Net.HttpandPrivate.InternalDiagnostics.System.Net.HttpMicrosoft-System-Net-Security->System.Net.SecurityandPrivate.InternalDiagnostics.System.Net.SecurityI noticed this when check support issue https://github.com/github/c2c-actions-support/issues/2691