-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node16 to latest version #2736
Conversation
@@ -149,8 +151,8 @@ fi | |||
# Download the external tools only for Windows. | |||
if [[ "$PACKAGERUNTIME" == "win-arm64" ]]; then | |||
# todo: replace these with official release when available | |||
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin | |||
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin | |||
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for explicit naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update node16 to latest * add available version for win-arm64 * fix externals hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Misc/contentHash/externals/linux-arm
src/Misc/contentHash/externals/linux-arm64
src/Misc/contentHash/externals/osx-arm64
src/Misc/contentHash/externals/osx-x64
src/Misc/contentHash/externals/win-arm64
src/Misc/contentHash/externals/win-x64
src/Misc/externals.sh
takost/update_latest_node16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update node16 to latest version - 16.20.1.
Node.js will be updated to 16.20.1 for all platforms except windows
win-arm64
, as this platform doesn't have this release.win-arm64
will be updated to latest available version 16.20.0