-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling for restore caching #297
Improve error handling for restore caching #297
Conversation
Deposit through the bitcoin wallet for any help |
Hello @brcrista. Could you please take a look at this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the change, but how does it relate to #295?
@actions/actions-cache, do you have any feedback? For context, the |
Hello @brcrista. Actually, as I checked the issue reproduces with node 16 only. On the previous action version it works as expected. I think it's related itself to the change of the default node version and buffer size. I could reproduce the same behaviour with action/cache when I removed this error handling logic and archive size was more than 2147483647. |
might this be related to actions/toolkit#1030 ? |
Thank you @aparna-ravindra. It works. I've updated the pull request. |
I'm going to close the pull request because the issue was resolved in scope of this pull request #308 |
Description:
In scope of this pull request we add error handling to throw error only for ValidationError.
Related issue: #295
Check list: