-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .node-version by default #683
Comments
Hello @stevelacey ! Thank you for the suggested idea! |
For comparison, ruby/setup-ruby supports this: |
@MaksimZhukov I am dropping by, not to +1, but to ask if there are any updates on the follow-up:
Thanks in advance! |
Description:
In addition to supporting the
node-version
andnode-version-file
inputs, the workflow should check.node-version
when neither input is supplied, and only fallback tolatest
if neither input was supplied, and that file does not exist.Justification:
Specifying
node-version
/node-version-file
in everysetup-node
usage is tedious and inconsistent with othersetup-{lang}
actions which usually check a version file by default in addition to supporting a{lang}-version-file
input.The setup-python and setup-ruby actions already do this, they use
.python-version
/.ruby-version
files if they exist and no inputs are passed, and setup-php will automatically use.php-version
once shivammathur/setup-php#690 is released.Are you willing to submit a PR?
Yes, absolutely, it may be worth supporting
.nvmrc
too given it's popularity, but maybe that's contentious, I haven't found any other actions that support a version manager's version file, though IIRC Heroku does honor it.The text was updated successfully, but these errors were encountered: